Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] n-api: create N-API version 7 #35337

Closed
wants to merge 1 commit into from
Closed

[v12.x] n-api: create N-API version 7 #35337

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Mark napi_detach_arraybuffer and napi_is_detached_arraybuffer as
stable.

Signed-off-by: @gabrielschulhof
PR-URL: #35199
Reviewed-By: @cjihrig
Reviewed-By: @gengjiawen
Reviewed-By: @legendecas
Reviewed-By: @mhdawson

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

n-api: create N-API version 7
aa122a9 
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as
stable.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: nodejs#35199
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <mdawson@devrus.com>
@gabrielschulhof gabrielschulhof added node-api Issues and PRs related to the Node-API. v12.x labels Sep 25, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2020 •
edited by mhdawson
Loading

Review requested:

  • @nodejs/n-api

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 25, 2020
mhdawson
mhdawson approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33251/

@addaleax
Copy link
Member

Landed in b9d0f73

@addaleax addaleax closed this Sep 28, 2020
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@addaleax
n-api: create N-API version 7
b9d0f73 
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as
stable.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #35199
Backport-PR-URL: #35337
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <mdawson@devrus.com>
@gabrielschulhof gabrielschulhof deleted the backport-n-api-7-to-v12.x branch January 28, 2021 00:14
@gabrielschulhof gabrielschulhof restored the backport-n-api-7-to-v12.x branch January 28, 2021 05:33
@gabrielschulhof gabrielschulhof deleted the backport-n-api-7-to-v12.x branch February 3, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gabrielschulhof @nodejs-github-bot @addaleax @gengjiawen @legendecas @mhdawson @richardlau